Re: [Qemu-devel] [PATCH v3 15/16] tci: Define TCG_TARGET_INSN_UNIT_SIZE

[Peter Maydell]

On 28 April 2014 20:28, Richard Henderson <address@hidden> wrote:
> And use tcg pointer differencing functions as appropriate.
>
> Cc: Stefan Weil <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  tcg/tci/tcg-target.c | 19 +++++++++++++------
>  tcg/tci/tcg-target.h |  1 +
>  2 files changed, 14 insertions(+), 6 deletions(-)

Reviewed-by: Peter Maydell <address@hidden>

though I note there are a number of functions that
use the pattern

    uint8_t *old_code_ptr = s->code_ptr;
    [...emit stuff...]
    old_code_ptr[1] = s->code_ptr - old_code_ptr;

which could perhaps use tcg_insn_unit * rather than uint8_t * ?

thanks
-- PMM