Re: [Qemu-devel] [PATCH] vl.c: Check max_cpus limit instead of smp_cpus

[Peter Maydell]

On 8 May 2014 16:00, Eduardo Habkost <address@hidden> wrote:
> On Thu, May 08, 2014 at 09:26:36AM +0100, Peter Maydell wrote:
>> On 7 May 2014 23:20, Andreas Färber <address@hidden> wrote:
>> > Am 07.05.2014 23:48, schrieb Peter Maydell:
>> >> This is confusing. What is max_cpus
>> >
>> > Specified via -smp, defaults to actual CPUs.
>>
>> I thought that was smp_cpus ...
>
> smp_cpus is the first argument to -smp. max_cpus is the "maxcpus" option
> of -smp.

> Please don't do this. If the maxcpus value from the command-line is not
> supported, QEMU should abort instead of silently ignoring the value
> provided by the user.

Ah, I see. This code is confusing because we've split the
handling of user errors in the -smp argument between
the smp_parse() function and this bit of inline code.
Ideally we should put all the error handling in one
place...

thanks
-- PMM