Re: [Qemu-devel] [PATCH v6 0/2] apic: bump emulated lapic version to 0x14

[Michael S. Tsirkin]

On Tue, May 06, 2014 at 11:17:23AM -0400, Gabriel L. Somlo wrote:
> This patch set changes the software-emulated local apic version
> to 0x14 starting with pc machine types 2.1 and newer. This should
> be particularly helpful when running OS X guests with TCG, since
> XNU appears to have a hardcoded requirement that lapic version >= 0x14.
> 
> Changelog:
> 
>   v6: - rebased to apply cleanly (no fuzz) against latest qemu git
>       - opportunity to practice dealing with Acked-by and Reviewed-by :)
> 
>   v5: convert lapic version to uint8_t (only 8 bits dedicated to
>       "implementation version" in the apic version register, according to
>       the Intel spec).
> 
>   v4: - split into a two-patch series with cover letter
>       - 1/2: - introduces empty 2.0 compat_props
>              - depends on 3458b2b075f92f163ccb9a1f24733eb5705947f0 to add
>                2.1 machine type and move aliases (now already upstream, but
>                not at the time v4 went out :)
>       - 2/2: - adds lapic version as a machine property defaulting to 0x14
>              - set to 0x11 in compat_props for machines 2.0 and older
> 
>   v3 and older: single patch, lapic version is global, no cover letter
> 
> Thanks again,
>   Gabriel


Applied, thanks for your patience.

> PS. Funny, now that I'm getting close to having figured out the qemu
> contributor netiquette, I'm just about done submitting all the changes
> I set out to contribute... :)
> 
> Gabriel L. Somlo (2):
>   pc: add compat_props placeholder for 2.0 machine type
>   pic: use emulated lapic version 0x14 on pc machines >= 2.1
> 
>  hw/i386/pc_piix.c               |  4 ++++
>  hw/i386/pc_q35.c                |  4 ++++
>  hw/intc/apic.c                  |  2 +-
>  hw/intc/apic_common.c           |  1 +
>  include/hw/i386/apic_internal.h |  1 +
>  include/hw/i386/pc.h            | 12 ++++++++++++
>  6 files changed, 23 insertions(+), 1 deletion(-)
> 
> -- 
> 1.9.0