qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] block: Fix open flags with BDRV_O_SNAPSHOT


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH] block: Fix open flags with BDRV_O_SNAPSHOT
Date: Wed, 7 May 2014 10:31:58 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, May 06, 2014 at 12:19:10PM +0200, Kevin Wolf wrote:
> The immediately visible effect of this patch is that it fixes committing
> a temporary snapshot to its backing file. Previously, it would fail with
> a "permission denied" error because bdrv_inherited_flags() forced the
> backing file to be read-only, ignoring the r/w reopen of bdrv_commit().
> 
> The bigger problem this releaved is that the original open flags must
> actually only be applied to the temporary snapshot, and the original
> image file must be treated as a backing file of the temporary snapshot
> and get the right flags for that.
> 
> Reported-by: Jan Kiszka <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block.c                    | 34 +++++++++++++++++++---------------
>  include/block/block.h      |  2 +-
>  tests/qemu-iotests/051     |  4 ++++
>  tests/qemu-iotests/051.out | 10 ++++++++++
>  4 files changed, 34 insertions(+), 16 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]