Re: [Qemu-devel] [PATCH v8 0/4] qemu-img: add preallocation=full

[Stefan Hajnoczi]

On Wed, Apr 09, 2014 at 03:12:33PM +0800, Hu Tao wrote:
> The purpose of this series is to use posix_fallocate() when creating
> img file to ensure there are disk space for it which is way fast than
> acturally writing to disk. But this only works in file system level.
> For cases like thin provisioning, an option full preallocation is
> added to write zeros to storage to ensure disk space.
> 
> Hu Tao (4):
>   qapi: introduce PreallocMode and a new PreallocMode full.
>   raw, qcow2: don't convert file size to sector size
>   raw-posix: Add full image preallocation option
>   qcow2: Add full image preallocation option
> 
>  block/qcow2.c              | 95 
> ++++++++++++++++++++++++++++++++++++++++------
>  block/raw-posix.c          | 63 ++++++++++++++++++++++++++----
>  block/raw-win32.c          |  4 +-
>  qapi-schema.json           | 14 +++++++
>  tests/qemu-iotests/082.out | 54 +++++++++++++-------------
>  5 files changed, 182 insertions(+), 48 deletions(-)

Kevin: You had review comments on the last revision.  Are you happy with
v8?

Stefan