[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH V4 4/6] hw/arm/virt: Use PSCI v0.2 compatibl
From: |
Pranavkumar Sawargaonkar |
Subject: |
Re: [Qemu-devel] [RFC PATCH V4 4/6] hw/arm/virt: Use PSCI v0.2 compatible when kernel supports it |
Date: |
Tue, 6 May 2014 10:54:01 +0530 |
Hi Rob, Peter,
On 5 May 2014 20:13, Peter Maydell <address@hidden> wrote:
> On 5 May 2014 15:09, Rob Herring <address@hidden> wrote:
>> On Mon, May 5, 2014 at 9:06 AM, Rob Herring <address@hidden> wrote:
>>> This does not compile for me:
>>>
>>> CC aarch64-softmmu/hw/arm/virt.o
>>> hw/arm/virt.c: In function ‘create_fdt’:
>>> hw/arm/virt.c:186:44: error: ‘KVM_CAP_ARM_PSCI_0_2’ undeclared (first
>>> use in this function)
>>> if (kvm_check_extension(kvm_state, KVM_CAP_ARM_PSCI_0_2)) {
>>> ^
>>
>> Note that I am building for system emulation, not KVM which may
>> explain the difference (I assume it actually builds for you).
>
Yes actually it builds for me since i am building KVM.
> Yes, you can't use the kernel header constants here, you need
> to use the QEMU_ variants that kvm-consts.h provides.
Sure I will do use QEMU_ variants in next patch so that it builds for
non KVM case also.
>
> thanks
> -- PMM
Thanks,
Pranav