[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] iotests: Use configured python
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] iotests: Use configured python |
Date: |
Mon, 05 May 2014 10:35:07 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/05/2014 10:25 AM, Max Reitz wrote:
>> The code generally uses the older `` notation instead of $(). Please
>> use ``.
>
> If I'd send a v2 with ``, Eric would probably want me to send a v3 with
> $(). ;-)
I won't make you resend if you are consistent with other code in the
same file. But I also won't object to someone tackling a generic
cleanup series to nuke ALL use of `` in the codebase.
>
> I personally don't really care what to use, but so far nobody has picked
> on me for using $(), whereas Eric once criticized my use of `` (which I
> had taken over from other tests).
Consistency trumps aesthetics; I can point out obsolete usages, but
won't reject a commit that is self-consistent in the use of that construct.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH] iotests: Use configured python, Max Reitz, 2014/05/03
- Re: [Qemu-devel] [PATCH] iotests: Use configured python, Stefan Hajnoczi, 2014/05/05
- Re: [Qemu-devel] [PATCH] iotests: Use configured python, Kevin Wolf, 2014/05/13
- Re: [Qemu-devel] [PATCH] iotests: Use configured python, Markus Armbruster, 2014/05/14
- Re: [Qemu-devel] [PATCH] iotests: Use configured python, Max Reitz, 2014/05/14
- Re: [Qemu-devel] [PATCH] iotests: Use configured python, Fam Zheng, 2014/05/14
- Re: [Qemu-devel] [PATCH] iotests: Use configured python, Markus Armbruster, 2014/05/15
- Re: [Qemu-devel] [PATCH] iotests: Use configured python, Markus Armbruster, 2014/05/15
- Re: [Qemu-devel] [PATCH] iotests: Use configured python, Max Reitz, 2014/05/15
- Re: [Qemu-devel] [PATCH] iotests: Use configured python, Peter Maydell, 2014/05/15
- Re: [Qemu-devel] [PATCH] iotests: Use configured python, Max Reitz, 2014/05/15