[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/13] qapi: Update qapi-code-gen.txt example to
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 01/13] qapi: Update qapi-code-gen.txt example to match current code |
Date: |
Sat, 03 May 2014 20:40:32 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/02/2014 06:44 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> docs/qapi-code-gen.txt | 146
> ++++++++++++++++++++++++++++++-------------------
> 1 file changed, 90 insertions(+), 56 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
I checked that this matches the current reality, and serves as a good
metric for what the rest of the series cleans up.
> === scripts/qapi-commands.py ===
>
> Used to generate the marshaling/dispatch functions for the commands defined
> @@ -356,18 +395,8 @@ $(prefix)qmp-commands.h: Function prototypes for the QMP
> commands
> Example:
>
> address@hidden:~/w/qemu2.git$ cat qapi-generated/example-qmp-marshal.c
The file was missing the example command line that generated this file;
I figured it out:
address@hidden:~/w/qemu2.git$ python scripts/qapi-commands.py \
--output-dir="qapi-generated" --prefix="example-" <
example-schema.json
if you want to add that to this patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 04/13] qapi: Replace start_optional()/end_optional() by optional(), Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH 08/13] qapi: Un-inline visit of implicit struct, Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH 03/13] qapi: Remove unused Visitor callbacks start_handle(), end_handle(), Markus Armbruster, 2014/05/02