[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: Use error_abort in bdrv_image_info_speci
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH] block: Use error_abort in bdrv_image_info_specific_dump() |
|
Date: |
Wed, 30 Apr 2014 12:43:45 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 29.04.2014 um 18:32 hat Max Reitz geschrieben:
> Currently, bdrv_image_info_specific_dump() uses an error variable for
> visit_type_ImageInfoSpecific, but ignores the result. As this function
> is used here with an output visitor to transform the ImageInfoSpecific
> object to a generic QDict, an error should actually be impossible. It is
> however better to assert that this is indeed the case. This is done by
> this patch using error_abort instead of an unused local Error variable.
>
> Signed-off-by: Max Reitz <address@hidden>
> Reported-by: Markus Armbruster <address@hidden>
Thanks, applied to the block branch.
Kevin