qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Makefile: Fix per-object variables for Makefile


From: Michael Tokarev
Subject: Re: [Qemu-devel] [PATCH] Makefile: Fix per-object variables for Makefile.target
Date: Wed, 30 Apr 2014 09:50:36 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.4.0

29.04.2014 10:29, Paolo Bonzini wrote:
[]
> What about this instead, does it do the same?
> 
> diff --git a/rules.mak b/rules.mak
> index 5c454d8..7038576 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -228,6 +228,7 @@ endef
>  define unnest-vars
>  $(eval obj := $1)
>  $(eval nested-vars := $2)
> +$(foreach v,$(nested-vars),$(call fix-obj-vars,$v,$(if $(obj),$(obj)/)))
>  $(eval old-nested-dirs := )
>  $(call unnest-vars-1)
>  $(if $1,$(foreach v,$(nested-vars),$(eval \

Reviewed-by: Michael Tokarev <address@hidden>

Oh well...  ;)

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]