[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 08/15] qapi: Drop redundant, unclean error_is
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH v2 08/15] qapi: Drop redundant, unclean error_is_set() |
Date: |
Tue, 29 Apr 2014 16:27:29 -0500 |
User-agent: |
alot/0.3.4 |
Quoting Markus Armbruster (2014-04-28 15:27:47)
> do_qmp_dispatch()'s test for qmp_dispatch_check_obj() failure examines
> both the return value and the error object. The latter part is
> unclean; it works only when do_qmp_dispatch()'s caller passes a
> non-null errp argument. That's the case, but it's not locally
> obvious. Unclean.
>
> Cleanup would be easy enough, but since the unclean code is also
> redundant, let's just drop it.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
> ---
> qapi/qmp-dispatch.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
> index 141a376..187af56 100644
> --- a/qapi/qmp-dispatch.c
> +++ b/qapi/qmp-dispatch.c
> @@ -67,9 +67,8 @@ static QObject *do_qmp_dispatch(QObject *request, Error
> **errp)
> QmpCommand *cmd;
> QObject *ret = NULL;
>
> -
> dict = qmp_dispatch_check_obj(request, errp);
> - if (!dict || error_is_set(errp)) {
> + if (!dict) {
> return NULL;
> }
>
> --
> 1.8.1.4
- [Qemu-devel] [PATCH v2 00/15] qmp qga: Purge error_is_set(), Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 04/15] qmp: Consistently name Error ** objects errp, and not err, Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 03/15] qga: Consistently name Error ** objects errp, and not err, Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 01/15] qmp hmp: Consistently name Error * objects err, and not errp, Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 02/15] qga: Consistently name Error ** objects errp, and not err, Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 05/15] error: Consistently name Error ** objects errp, and not err, Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 08/15] qapi: Drop redundant, unclean error_is_set(), Markus Armbruster, 2014/04/28
- Re: [Qemu-devel] [PATCH v2 08/15] qapi: Drop redundant, unclean error_is_set(),
Michael Roth <=
- [Qemu-devel] [PATCH v2 13/15] qemu-option: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 11/15] qga: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 10/15] qapi: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 15/15] qmp: Don't use error_is_set() to suppress additional errors, Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 12/15] qga: Drop superfluous error_is_set(), Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 07/15] hmp: Guard against misuse of hmp_handle_error(), Markus Armbruster, 2014/04/28
- [Qemu-devel] [PATCH v2 09/15] tests/qapi-schema: Drop superfluous error_is_set(), Markus Armbruster, 2014/04/28