qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/6] block: Unlink temporary files in raw-posix/


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH 4/6] block: Unlink temporary files in raw-posix/win32
Date: Tue, 29 Apr 2014 18:01:26 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

On 25.04.2014 19:51, Kevin Wolf wrote:
Instead of having unlink() calls in the generic block layer, where we
aren't even guarateed to have a file name, move them to those block
drivers that are actually used and that always have a filename. Gets us
rid of some #ifdefs as well.

The patch also converts bs->is_temporary to a new BDRV_O_TEMPORARY open
flag so that it is inherited in the protocol layer and the raw-posix and
raw-win32 drivers can unlink the file.

Signed-off-by: Kevin Wolf <address@hidden>
---
  block.c                   | 36 ++++++++++--------------------------
  block/raw-posix.c         |  5 ++++-
  block/raw-win32.c         |  3 +++
  include/block/block.h     |  1 +
  include/block/block_int.h |  1 -
  5 files changed, 18 insertions(+), 28 deletions(-)

Reviewed-by: Max Reitz <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]