Re: [Qemu-devel] [PATCH 5/5] linux-user/signal.c: define __SIGRTMIN/MAX for non-GNU platforms

[Eric Blake]

On 04/29/2014 08:17 AM, Natanael Copa wrote:
> The __SIGRTMIN and __SIGRTMAX are glibc internals and are not available
> on all platforms, so we define those if they are missing.
> 
> This is needed for musl libc.
> 
> Signed-off-by: Natanael Copa <address@hidden>
> ---
>  linux-user/signal.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/linux-user/signal.c b/linux-user/signal.c
> index 7d6246f..6019dbb 100644
> --- a/linux-user/signal.c
> +++ b/linux-user/signal.c
> @@ -32,6 +32,13 @@
>  
>  //#define DEBUG_SIGNAL
>  
> +#ifndef __SIGRTMIN
> +#define __SIGRTMIN 32

Rather than defining the implementation-specific __SIGRTMIN to a magic
number that is liable to be wrong, why not instead fix the code to use
the POSIX-mandated SIGRTMIN and SIGRTMAX public defines instead?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature