Re: [Qemu-devel] [PATCH 2/2] usb: mtp: reply INCOMPLETE_TRANSFER on read errors

[Peter Wu]

On Tuesday 29 April 2014 10:43:52 Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <address@hidden>

Reviewed-by: Peter Wu <address@hidden>

> ---
>  hw/usb/dev-mtp.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
> index 62428d8..943f930 100644
> --- a/hw/usb/dev-mtp.c
> +++ b/hw/usb/dev-mtp.c
> @@ -50,6 +50,7 @@ enum mtp_code {
>      RES_INVALID_TRANSACTION_ID     = 0x2004,
>      RES_OPERATION_NOT_SUPPORTED    = 0x2005,
>      RES_PARAMETER_NOT_SUPPORTED    = 0x2006,
> +    RES_INCOMPLETE_TRANSFER        = 0x2007,
>      RES_INVALID_STORAGE_ID         = 0x2008,
>      RES_INVALID_OBJECT_HANDLE      = 0x2009,
>      RES_SPEC_BY_FORMAT_UNSUPPORTED = 0x2014,
> @@ -946,7 +947,8 @@ static void usb_mtp_handle_data(USBDevice *dev, USBPacket 
> *p)
>                  }
>                  rc = read(d->fd, d->data, dlen);
>                  if (rc != dlen) {
> -                    fprintf(stderr, "%s: TODO: handle read error\n", 
> __func__);
> +                    memset(d->data, 0, dlen);
> +                    s->result->code = RES_INCOMPLETE_TRANSFER;
>                  }
>                  usb_packet_copy(p, d->data, dlen);
>              }
>