[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4] mirror: Check for bdrv_get_info result
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v4] mirror: Check for bdrv_get_info result |
Date: |
Tue, 29 Apr 2014 18:14:17 +0800 |
bdrv_get_info could fail. Add check before using the returned value.
Signed-off-by: Fam Zheng <address@hidden>
---
v4: Don't call block_job_completed twice. (kevin)
v3: Don't leak things, jump to immediate_exit. (Kevin)
Signed-off-by: Fam Zheng <address@hidden>
---
block/mirror.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/block/mirror.c b/block/mirror.c
index 36f4f8e..aadc618 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -339,7 +339,10 @@ static void coroutine_fn mirror_run(void *opaque)
bdrv_get_backing_filename(s->target, backing_filename,
sizeof(backing_filename));
if (backing_filename[0] && !s->target->backing_hd) {
- bdrv_get_info(s->target, &bdi);
+ ret = bdrv_get_info(s->target, &bdi);
+ if (ret < 0) {
+ goto immediate_exit;
+ }
if (s->granularity < bdi.cluster_size) {
s->buf_size = MAX(s->buf_size, bdi.cluster_size);
s->cow_bitmap = bitmap_new(length);
--
1.9.2
- [Qemu-devel] [PATCH v4] mirror: Check for bdrv_get_info result,
Fam Zheng <=