Re: [Qemu-devel] [PATCH] -nographic sometimes adds an extra chardev for stdio

[Michael Tokarev]

address@hidden bounces, removed from Cc]

29.04.2014 00:07, Mike Day wrote:
[]
> Suggestions much appreciated, I think its ugly versus intrusive, but
> I'm not familiar with this part of qemu.
> 
> There is another case with -monitor where you can configure two
> chardevs for stdio and it does the same thing. I left that one alone,
> its more complicated.

Actually it looks like we should protect from fighting for stdio from
various places.  We already had something similar in commit
ab51b1d568e02c80b1abf9016bda3a86dc1db389 -- see bits in qemu-char.c.

I guess we should have some global variable like "stdio_occuped", set
it to 1 when -daemonize is specified, and set and check it each time
we try to use stdio for something.  This way we'll prevent various
parts of qemu from fighting for stdio.

I don't have time right now to do that, maybe later today or this
week.

Thanks!

/mjt