qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] tests/tcg: Fix compilation of test_path


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] tests/tcg: Fix compilation of test_path
Date: Mon, 28 Apr 2014 20:45:01 +0100

On 28 April 2014 20:35, Peter Maydell <address@hidden> wrote:
> --- a/tests/tcg/Makefile
> +++ b/tests/tcg/Makefile
> @@ -81,10 +81,10 @@ run-test_path: test_path
>  # rules to compile tests
>
>  test_path: test_path.o
> -       $(CC_I386) $(LDFLAGS) -o $@ $^ $(LIBS)
> +       $(CC) $(LDFLAGS) -o $@ $^ $(LIBS)
>
>  test_path.o: test_path.c
> -       $(CC_I386) $(QEMU_INCLUDES) $(GLIB_CFLAGS) $(CFLAGS) -c -o $@ $^
> +       $(CC) $(QEMU_INCLUDES) $(GLIB_CFLAGS) $(CFLAGS) -c -o $@ $^

In fact we can drop these CC lines altogether (going back
to the situation before commit f62cb1b6d) -- we failed to
notice then that test_path is an oddball, being a host
binary rather than a target binary, unlike all the other
files being compiled in this directory.

(Also means _GNU_SOURCE needs to be removed from the
.c file as otherwise the compiler complains that it's
defined on the command line and in the c file.)

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]