qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] scsi: Improve error messages more


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH v2] scsi: Improve error messages more
Date: Mon, 28 Apr 2014 18:12:52 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

Am 28.04.2014 13:39, schrieb Paolo Bonzini:
> Remove the "scsi-block:" prefix for error messages as suggested
> by Markus.
> 
> Improve the previous patch by making the message the same for both
> scsi-block and scsi-generic, including the strerror() output in both
> and making an explicit reference to SG_IO.  Also s/can not/cannot/.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>

Reviewed-by: Andreas Färber <address@hidden>

> ---
>  hw/scsi/scsi-disk.c    | 11 ++++++-----
>  hw/scsi/scsi-generic.c |  8 ++++++--
>  2 files changed, 12 insertions(+), 7 deletions(-)
> 
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index d2e532e..4bcef55 100644
> --- a/hw/scsi/scsi-disk.c
> +++ b/hw/scsi/scsi-disk.c
> @@ -2458,26 +2458,27 @@ static int scsi_block_initfn(SCSIDevice *dev)
>      int rc;
>  
>      if (!s->qdev.conf.bs) {
> -        error_report("scsi-block: drive property not set");
> +        error_report("drive property not set");

But these error_report()s in ..._initfn() are loudly calling for a
conversion to QOM realize and error_setg(). :)

Maybe a task for a GSoC student, if - gentle reminder after the vacation
- tests are made available to verify?

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]