Re: [Qemu-devel] [PATCH] libcacard: actually use symbols file

[Michael Tokarev]

27.04.2014 19:11, Andreas Färber wrote:
> Am 27.04.2014 16:37, schrieb Michael Tokarev:
>> libtool has an argument for .syms file, which is -export-symbols.
>> There's no argument `-export-syms', and it looks like at least on
>> linux, -export-syms is just ignored.  Use the correct argument,
>> -export-symbols, to actually get the right export list.
>>
>> But it turns out that vscclient binary, which also uses qemu
>> privitives for sockets, mutexes and some other stuff, but only
> 
> "primitives"?
> 
>> linked with libcacard, does not link after hiding extra symbols
>> previously exported by libcacard.  So while at it, link it with
>> libqemuutil.a and libqemustub.a.  This makes the binary as twice
> 
> "twice as large" (without leading "as")

Ok.  Typos-typos...

[]
>> -vscclient$(EXESUF): libcacard/vscclient.o libcacard.la
>> +vscclient$(EXESUF): libcacard/vscclient.o libcacard.la libqemuutil.a 
>> libqemustub.a
> 
> No objection, but what symbol(s) is libqemustub.a needed for?

It is needed for many things on which libqemuutil.a depends, -- stuff like 
monitor_fd
and other.

But I think I've a much better idea in two subsequent patches I just submitted 
- one
for vscclient and another for libcacard: it is to eliminate the need to use any
qemu internals to start with, because all that is already provided by glib.
After that, the first version of this patch (the one-liner, which replaces
-export-syms with -export-symbols) can be applied instead, and everything will
be much saner.

See emails from me titled

 "vscclient: use glib thread primitives not qemu"
 "libcacard: replace qemu thread primitives with glib ones".

But please note: compile-time tested only.  I don't even know what this stuff 
_is_ ;)

Thanks,

/mjt