[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH V5 1/1] qmp: add pmemload command
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH V5 1/1] qmp: add pmemload command |
Date: |
Sun, 27 Apr 2014 13:18:17 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.4.0 |
09.04.2014 21:49, Baojun Wang wrote:
> I found this could be useful to have qemu-softmmu as a cross debugger (launch
> with -s -S command line option), then if we can have a command to load guest
> physical memory, we can use cross gdb to do some target debug which gdb cannot
> do directly.
>
> Many thanks to Eric Blake for review the patch and suggestions.
Okay, that looks sane, but can you explain please, why did you address
address@hidden The change definitely is not "trivial", as it introduces
a new qmp command which becomes a part of public interface. Even if
the implementation may look trivial, the interface change should not be
done using -trivial tree.
Thanks,
/mjt
- [Qemu-devel] [PATCH V3 1/1] Add pmemsave command for both monitor and qmp, which could be useful to have qemu-softmmu as a cross debugger to load guest physical memory., Baojun Wang, 2014/04/08
- Re: [Qemu-devel] [PATCH V3 1/1] Add pmemsave command for both monitor and qmp, which could be useful to have qemu-softmmu as a cross debugger to load guest physical memory., Eric Blake, 2014/04/08
- Re: [Qemu-devel] [PATCH V3 1/1] Add pmemsave command for both monitor and qmp, which could be useful to have qemu-softmmu as a cross debugger to load guest physical memory., Baojun Wang, 2014/04/08
- [Qemu-devel] [PATCH V4 1/1] qmp: add pmemload command, Baojun Wang, 2014/04/09
- Re: [Qemu-devel] [PATCH V4 1/1] qmp: add pmemload command, Eric Blake, 2014/04/09
- [Qemu-devel] [PATCH V5 1/1] qmp: add pmemload command, Baojun Wang, 2014/04/09
- Re: [Qemu-devel] [Qemu-trivial] [PATCH V5 1/1] qmp: add pmemload command,
Michael Tokarev <=
- Re: [Qemu-devel] [Qemu-trivial] [PATCH V5 1/1] qmp: add pmemload command, Markus Armbruster, 2014/04/28
- Re: [Qemu-devel] [Qemu-trivial] [PATCH V5 1/1] qmp: add pmemload command, Baojun Wang, 2014/04/30