[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 3/4] s390x/kvm: rework KVM synchronize to tracing
|
From: |
Christian Borntraeger |
|
Subject: |
Re: [Qemu-devel] [PULL 3/4] s390x/kvm: rework KVM synchronize to tracing for some ONEREGS |
|
Date: |
Fri, 25 Apr 2014 14:24:45 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 25/04/14 14:04, Alexander Graf wrote:
>
> On 25.04.14 14:02, Cornelia Huck wrote:
>> From: Christian Borntraeger <address@hidden>
>>
>> Some ONE_REGS on s390 are not protected by a capability. Older kernels
>> might not provide those and return an error. Fortunately these registers
>> are only critical for the migration path. There is no need to error out
>> on reset and normal runtime. Furthermore, these kernels don't provide
>> a proper dirty bitmap anyway, so let's use tracing for those errors.
>>
>> Also provide generic one reg helper to simplify the code.
>>
>> Signed-off-by: Christian Borntraeger <address@hidden>
>> Reviewed-by: Cornelia Huck <address@hidden>
>> Signed-off-by: Cornelia Huck <address@hidden>
>
> CC stable?
Makes sense. get_registers is fine as the ONE_REGS are at the end of the
function,
but put_registers will not store the SREGS and the prefix in that case.
I guess its ok to send the patch and the commit id to qemu stable after
this hits master?
Christian