Re: [Qemu-devel] [PATCH v2 1/2] qapi: fix coding style in parameters list

[Fam Zheng]

On Fri, 04/25 15:56, Amos Kong wrote:
> The space before point is redundant.

s/point/pointer

Fam

> 
> Signed-off-by: Amos Kong <address@hidden>
> ---
>  scripts/qapi-visit.py | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py
> index 45ce3a9..8ffed3d 100644
> --- a/scripts/qapi-visit.py
> +++ b/scripts/qapi-visit.py
> @@ -38,7 +38,7 @@ def generate_visit_struct_fields(name, field_prefix, 
> fn_prefix, members, base =
>  
>      ret += mcgen('''
>  
> -static void visit_type_%(full_name)s_fields(Visitor *m, %(name)s ** obj, 
> Error **errp)
> +static void visit_type_%(full_name)s_fields(Visitor *m, %(name)s **obj, 
> Error **errp)
>  {
>      Error *err = NULL;
>  ''',
> @@ -149,7 +149,7 @@ def generate_visit_struct(expr):
>  
>      ret += mcgen('''
>  
> -void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, 
> Error **errp)
> +void visit_type_%(name)s(Visitor *m, %(name)s **obj, const char *name, Error 
> **errp)
>  {
>  ''',
>                  name=name)
> @@ -166,7 +166,7 @@ void visit_type_%(name)s(Visitor *m, %(name)s ** obj, 
> const char *name, Error **
>  def generate_visit_list(name, members):
>      return mcgen('''
>  
> -void visit_type_%(name)sList(Visitor *m, %(name)sList ** obj, const char 
> *name, Error **errp)
> +void visit_type_%(name)sList(Visitor *m, %(name)sList **obj, const char 
> *name, Error **errp)
>  {
>      GenericList *i, **prev = (GenericList **)obj;
>      Error *err = NULL;
> @@ -193,7 +193,7 @@ void visit_type_%(name)sList(Visitor *m, %(name)sList ** 
> obj, const char *name,
>  def generate_visit_enum(name, members):
>      return mcgen('''
>  
> -void visit_type_%(name)s(Visitor *m, %(name)s * obj, const char *name, Error 
> **errp)
> +void visit_type_%(name)s(Visitor *m, %(name)s *obj, const char *name, Error 
> **errp)
>  {
>      visit_type_enum(m, (int *)obj, %(name)s_lookup, "%(name)s", name, errp);
>  }
> @@ -203,7 +203,7 @@ void visit_type_%(name)s(Visitor *m, %(name)s * obj, 
> const char *name, Error **e
>  def generate_visit_anon_union(name, members):
>      ret = mcgen('''
>  
> -void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, 
> Error **errp)
> +void visit_type_%(name)s(Visitor *m, %(name)s **obj, const char *name, Error 
> **errp)
>  {
>      Error *err = NULL;
>  
> @@ -279,7 +279,7 @@ def generate_visit_union(expr):
>  
>      ret += mcgen('''
>  
> -void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, 
> Error **errp)
> +void visit_type_%(name)s(Visitor *m, %(name)s **obj, const char *name, Error 
> **errp)
>  {
>      Error *err = NULL;
>  
> @@ -367,13 +367,13 @@ def generate_declaration(name, members, genlist=True, 
> builtin_type=False):
>      if not builtin_type:
>          ret += mcgen('''
>  
> -void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, 
> Error **errp);
> +void visit_type_%(name)s(Visitor *m, %(name)s **obj, const char *name, Error 
> **errp);
>  ''',
>                      name=name)
>  
>      if genlist:
>          ret += mcgen('''
> -void visit_type_%(name)sList(Visitor *m, %(name)sList ** obj, const char 
> *name, Error **errp);
> +void visit_type_%(name)sList(Visitor *m, %(name)sList **obj, const char 
> *name, Error **errp);
>  ''',
>                   name=name)
>  
> @@ -383,7 +383,7 @@ def generate_enum_declaration(name, members, 
> genlist=True):
>      ret = ""
>      if genlist:
>          ret += mcgen('''
> -void visit_type_%(name)sList(Visitor *m, %(name)sList ** obj, const char 
> *name, Error **errp);
> +void visit_type_%(name)sList(Visitor *m, %(name)sList **obj, const char 
> *name, Error **errp);
>  ''',
>                       name=name)
>  
> @@ -392,7 +392,7 @@ void visit_type_%(name)sList(Visitor *m, %(name)sList ** 
> obj, const char *name,
>  def generate_decl_enum(name, members, genlist=True):
>      return mcgen('''
>  
> -void visit_type_%(name)s(Visitor *m, %(name)s * obj, const char *name, Error 
> **errp);
> +void visit_type_%(name)s(Visitor *m, %(name)s *obj, const char *name, Error 
> **errp);
>  ''',
>                  name=name)
>  
> -- 
> 1.9.0
>