Re: [Qemu-devel] [PATCH 2/5] qemu-img: Consistently name Error * objects err, and not errp

[Kevin Wolf]

Am 24.04.2014 um 11:15 hat Markus Armbruster geschrieben:
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  qemu-img.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/qemu-img.c b/qemu-img.c
> index 8455994..88124bf 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -442,12 +442,12 @@ fail:
>  
>  static void dump_json_image_check(ImageCheck *check, bool quiet)
>  {
> -    Error *errp = NULL;
> +    Error *err = NULL;
>      QString *str;
>      QmpOutputVisitor *ov = qmp_output_visitor_new();
>      QObject *obj;
>      visit_type_ImageCheck(qmp_output_get_visitor(ov),
> -                          &check, NULL, &errp);
> +                          &check, NULL, &err);
>      obj = qmp_output_get_qobject(ov);
>      str = qobject_to_json_pretty(obj);
>      assert(str != NULL);

I'd like to have my bikeshed green: Can we use local_err instead, please?

Kevin