[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL for-2.1 10/25] tcg-aarch64: Use CBZ and CBNZ
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL for-2.1 10/25] tcg-aarch64: Use CBZ and CBNZ |
Date: |
Wed, 16 Apr 2014 09:17:53 -0700 |
A compare and branch against zero happens at the start of
every single TB.
Reviewed-by: Claudio Fontana <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
tcg/aarch64/tcg-target.c | 26 ++++++++++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
index 5889a98..48a246d 100644
--- a/tcg/aarch64/tcg-target.c
+++ b/tcg/aarch64/tcg-target.c
@@ -270,6 +270,10 @@ enum aarch64_ldst_op_type { /* type of operation */
use the section number of the architecture reference manual in which the
instruction group is described. */
typedef enum {
+ /* Compare and branch (immediate). */
+ I3201_CBZ = 0x34000000,
+ I3201_CBNZ = 0x35000000,
+
/* Conditional branch (immediate). */
I3202_B_C = 0x54000000,
@@ -433,6 +437,12 @@ static inline uint32_t tcg_in32(TCGContext *s)
#define tcg_out_insn(S, FMT, OP, ...) \
glue(tcg_out_insn_,FMT)(S, glue(glue(glue(I,FMT),_),OP), ## __VA_ARGS__)
+static void tcg_out_insn_3201(TCGContext *s, AArch64Insn insn, TCGType ext,
+ TCGReg rt, int imm19)
+{
+ tcg_out32(s, insn | ext << 31 | (imm19 & 0x7ffff) << 5 | rt);
+}
+
static void tcg_out_insn_3202(TCGContext *s, AArch64Insn insn,
TCGCond c, int imm19)
{
@@ -913,8 +923,14 @@ static void tcg_out_brcond(TCGContext *s, TCGMemOp ext,
TCGCond c, TCGArg a,
{
TCGLabel *l = &s->labels[label];
intptr_t offset;
+ bool need_cmp;
- tcg_out_cmp(s, ext, a, b, b_const);
+ if (b_const && b == 0 && (c == TCG_COND_EQ || c == TCG_COND_NE)) {
+ need_cmp = false;
+ } else {
+ need_cmp = true;
+ tcg_out_cmp(s, ext, a, b, b_const);
+ }
if (!l->has_value) {
tcg_out_reloc(s, s->code_ptr, R_AARCH64_CONDBR19, label, 0);
@@ -925,7 +941,13 @@ static void tcg_out_brcond(TCGContext *s, TCGMemOp ext,
TCGCond c, TCGArg a,
assert(offset >= -0x40000 && offset < 0x40000);
}
- tcg_out_insn(s, 3202, B_C, c, offset);
+ if (need_cmp) {
+ tcg_out_insn(s, 3202, B_C, c, offset);
+ } else if (c == TCG_COND_EQ) {
+ tcg_out_insn(s, 3201, CBZ, ext, a, offset);
+ } else {
+ tcg_out_insn(s, 3201, CBNZ, ext, a, offset);
+ }
}
static inline void tcg_out_rev(TCGContext *s, TCGType ext,
--
1.9.0
- [Qemu-devel] [PULL for-2.1 00/25] tcg-aarch64 improvements, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 01/25] tcg-aarch64: Properly detect SIGSEGV writes, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 02/25] tcg-aarch64: Use intptr_t apropriately, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 03/25] tcg-aarch64: Use TCGType and TCGMemOp constants, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 04/25] tcg-aarch64: Use MOVN in tcg_out_movi, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 05/25] tcg-aarch64: Use ORRI in tcg_out_movi, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 07/25] tcg-aarch64: Use adrp in tcg_out_movi, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 06/25] tcg-aarch64: Special case small constants in tcg_out_movi, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 08/25] tcg-aarch64: Use symbolic names for branches, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 10/25] tcg-aarch64: Use CBZ and CBNZ,
Richard Henderson <=
- [Qemu-devel] [PULL for-2.1 11/25] tcg-aarch64: Reuse LR in translated code, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 12/25] tcg-aarch64: Introduce tcg_out_insn_3314, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 14/25] tcg-aarch64: Avoid add with zero in tlb load, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 09/25] tcg-aarch64: Create tcg_out_brcond, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 15/25] tcg-aarch64: Use tcg_out_call for qemu_ld/st, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 16/25] tcg-aarch64: Use ADR to pass the return address to the ld/st helpers, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 17/25] tcg-aarch64: Use TCGMemOp in qemu_ld/st, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 18/25] tcg-aarch64: Pass qemu_ld/st arguments directly, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 13/25] tcg-aarch64: Implement tcg_register_jit, Richard Henderson, 2014/04/16
- [Qemu-devel] [PULL for-2.1 20/25] tcg-aarch64: Support stores of zero, Richard Henderson, 2014/04/16