Re: [Qemu-devel] [PATCH 1/7] megasas: Enable MSI-X support

[Alexander Graf]

On 16.04.14 13:49, Hannes Reinecke wrote:
> On 04/16/2014 01:43 PM, Alexander Graf wrote:
> > On 16.04.14 09:16, Hannes Reinecke wrote:
> > > MSI-X support has been fixed in qemu, so we can enable it again.
> > >
> > > Signed-off-by: Hannes Reinecke <address@hidden>
> > > ---
> > >    hw/scsi/megasas.c | 20 ++++++--------------
> > >    1 file changed, 6 insertions(+), 14 deletions(-)
> > >
> > > diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
> > > index e6e1ffd..496bab8 100644
> > > --- a/hw/scsi/megasas.c
> > > +++ b/hw/scsi/megasas.c
> > > @@ -29,7 +29,7 @@
> > >      #include "mfi.h"
> > >    -#define MEGASAS_VERSION "1.70"
> > > +#define MEGASAS_VERSION "1.71"
> > What happens when I create a VM on 2.0 and then run it with 2.1?
> > Will the VM see a difference?
> The only difference you'll see is a different PCI configuration.
> Other than that the behaviour will be identical.

Hrm. Can we keep this at 1.70 for the old PCI model and bump to 1.80 for 
the new one?

> For compatible behaviour you'd need to set 'use_msix=false' in the
> megasas configuration.
>
> If this really is an issue I can re-sent the patch with defaulting
> back to 'false'.

I think it makes sense to default to "false" for the old device type only.


Alex