Re: [Qemu-devel] [PATCH for-2.0] qom: Fix crash with qom-list and link properties

[Peter Maydell]

On 11 April 2014 17:57, Andreas Färber <address@hidden> wrote:
> Am 10.04.2014 20:47, schrieb Cole Robinson:
>> Commit 9561fda8d90e176bef598ba87c42a1bd6ad03ef7 changed the type of
>> 'opaque' for link properties, but missed updating this call site.
>> Reproducer:
>>
>> ./x86_64-softmmu/qemu-system-x86_64 -qmp unix:./qmp.sock,server &
>> ./scripts/qmp/qmp-shell ./qmp.sock
>> (QEMU) qom-list path=//machine/i440fx/pci.0/child[2]
>
> I would much prefer if we could give the path as just
> path=/machine/i440fx/pci.0/child[2] (without double slash). Peter can
> you improve when applying?

Sorry, had already pushed before I read this.


>>
>> Reported-by: Marcin Gibuła <address@hidden>
>> Signed-off-by: Cole Robinson <address@hidden>
>> ---
>>  qom/object.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> Reviewed-by: Andreas Färber <address@hidden>
>
> I would like to remark that specifically for regression-testing link<>
> properties I had extended qom-test, and it succeeds currently. So Cole,
> if you have any suggestion on how to extend it to catch this regression
> that would be welcome.

Applied, thanks.

-- PMM