Re: [Qemu-devel] [PATCH] QEMU: ARM: boot: Load kernel at an Image friendly address

[Peter Crosthwaite]

On Wed, Apr 2, 2014 at 3:10 AM, Peter Maydell <address@hidden> wrote:
> On 25 March 2014 03:34, Joel Fernandes <address@hidden> wrote:
>> Loading kernel at offset 0x10000 works only for zImage, but not for Image,
>> because the kernel expect the start of decompressed kernel (.head.text) to be
>> at an address that's a distance that's 16MB aligned from  PAGE_OFFSET +
>> TEXT_OFFSET (see vmlinux.lds.S). This check is enfornced in __fixup_pv_table 
>> in
>> arch/arm/kernel/head.S TEXT_OFFSET is 0x00008000, so a 16MB alignment needs 
>> to
>> have a "0x8000" in the lower 16 bits so that they cancel out. Currently the
>> offset Qemu loads it at is 0x10000.
>>
>> With zImage, this need is met because zImage loads the uncompressed Image
>> correctly, however when loading an Image and executing directly Qemu is
>> required it to load it at the correct location. Doing so, doesn't break 
>> Qemu's
>> zImage loading. With this patch, both zImage and Image work correctly.
>>
>> Signed-off-by: Joel Fernandes <address@hidden>
>
> Reviewed-by: Peter Maydell <address@hidden>
>

Like others, I have been carrying this change locally. Good to see it up!

Reviewed-by: Peter Crosthwaite <address@hidden>
Tested-by: Peter Crosthwaite <address@hidden>

> I'll put this in target-arm.next after 2.0 has released.
>
> thanks
> -- PMM
>