[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH trival] vl.c: clean up code
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH trival] vl.c: clean up code |
Date: |
Tue, 01 Apr 2014 15:33:42 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Chen Gang <address@hidden> writes:
> On 04/01/2014 04:13 PM, Markus Armbruster wrote:
>> Chen Gang <address@hidden> writes:
>>
>>> On 03/31/2014 11:49 PM, Markus Armbruster wrote:
>>>> Chen Gang <address@hidden> writes:
>>>>
>>>>> in get_boot_device()
>>>>>
>>>>> - remove 'res' to simplify code
>>>>>
>>>>> in main():
>>>>>
>>>>> - remove useless 'continue'.
>>>>>
>>>>> - in main switch():
>>>>>
>>>>> - remove or adjust all useless 'break'.
>>>>>
>>>>> - remove useless '{' and '}'.
>>>>>
>>>>> - use assignment directly to replace useless 'args'
>>>>> (which is defined in the middle of code block).
>>>>
>>>> Suggest to have one patch per item in this list.
>>>>
>>>
>>> OK, thanks. I will/should send again in this week (within 2014-04-06).
>>
>> No rush :)
>>
>
> Yeah, more discussions, and more thinking of, before implementations.
What I meant to say is "next week is fine, we're not in a big hurry to
get this done".