[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL for-2.0 05/16] tests: Correctly skip qtest on non-POS
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PULL for-2.0 05/16] tests: Correctly skip qtest on non-POSIX hosts |
Date: |
Mon, 31 Mar 2014 23:10:51 +0200 |
From: Stefan Hajnoczi <address@hidden>
qtest test cases only work on POSIX hosts. The following line only
defines dependencies for qtest binaries on POSIX hosts:
check-qtest-$(CONFIG_POSIX)=$(foreach
TARGET,$(TARGETS),$(check-qtest-$(TARGET)-y))
But the QTEST_TARGETS definition earlier in the Makefile fails to check
CONFIG_POSIX. This causes make targets to be generated for qtest test
cases even though we don't know how to build the binaries.
The following error message is printed when trying to run gtester on a
binary that was never built:
GLib-WARNING **: Failed to execute test binary: tests/endianness-test.exe:
Failed to execute child process "tests/endianness-test.exe" (No such file or
directory)
This patch makes QTEST_TARGETS empty on non-POSIX hosts. This prevents
the targets from being generated.
Signed-off-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
---
tests/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/Makefile b/tests/Makefile
index ef286e7..0e3eb44 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -277,8 +277,10 @@ tests/qemu-iotests/socket_scm_helper$(EXESUF):
tests/qemu-iotests/socket_scm_hel
# QTest rules
TARGETS=$(patsubst %-softmmu,%, $(filter %-softmmu,$(TARGET_DIRS)))
+ifeq ($(CONFIG_POSIX),y)
QTEST_TARGETS=$(foreach TARGET,$(TARGETS), $(if $(check-qtest-$(TARGET)-y),
$(TARGET),))
-check-qtest-$(CONFIG_POSIX)=$(foreach TARGET,$(TARGETS),
$(check-qtest-$(TARGET)-y))
+check-qtest-y=$(foreach TARGET,$(TARGETS), $(check-qtest-$(TARGET)-y))
+endif
qtest-obj-y = tests/libqtest.o libqemuutil.a libqemustub.a
$(check-qtest-y): $(qtest-obj-y)
--
1.8.4.5
- [Qemu-devel] [PULL for-2.0 00/16] QOM devices patch queue 2014-03-31, Andreas Färber, 2014/03/31
- [Qemu-devel] [PULL for-2.0 03/16] tests: Remove unsupported tests for MinGW, Andreas Färber, 2014/03/31
- [Qemu-devel] [PULL for-2.0 02/16] qtest: Keep list of qtest instances for SIGABRT handler, Andreas Färber, 2014/03/31
- [Qemu-devel] [PULL for-2.0 04/16] tests: Skip POSIX-only tests on Windows, Andreas Färber, 2014/03/31
- [Qemu-devel] [PULL for-2.0 07/16] tests: Add nvme qtest, Andreas Färber, 2014/03/31
- [Qemu-devel] [PULL for-2.0 08/16] tests: Add virtio-9p qtest, Andreas Färber, 2014/03/31
- [Qemu-devel] [PULL for-2.0 06/16] nvme: Permit zero-length block devices, Andreas Färber, 2014/03/31
- [Qemu-devel] [PULL for-2.0 05/16] tests: Correctly skip qtest on non-POSIX hosts,
Andreas Färber <=
- [Qemu-devel] [PULL for-2.0 01/16] Revert "qtest: Fix crash if SIGABRT during qtest_init()", Andreas Färber, 2014/03/31
- [Qemu-devel] [PULL for-2.0 10/16] qtest: Factor out qtest_qmp_receive(), Andreas Färber, 2014/03/31
- [Qemu-devel] [PULL for-2.0 11/16] pvpanic-test: Assert pause event, Andreas Färber, 2014/03/31
- [Qemu-devel] [PULL for-2.0 12/16] tests: Add i82801b11 qtest, Andreas Färber, 2014/03/31
- [Qemu-devel] [PULL for-2.0 09/16] tests: Add pvpanic qtest, Andreas Färber, 2014/03/31
- [Qemu-devel] [PULL for-2.0 13/16] tmp105: Read temperature in milli-celsius, Andreas Färber, 2014/03/31
- [Qemu-devel] [PULL for-2.0 15/16] tmp105-test: Add a second sensor and test that one, Andreas Färber, 2014/03/31
- [Qemu-devel] [PULL for-2.0 14/16] tmp105-test: Wrap simple building blocks for testing, Andreas Färber, 2014/03/31
- [Qemu-devel] [PULL for-2.0 16/16] tmp105-test: Test QOM property and precision, Andreas Färber, 2014/03/31