Re: [Qemu-devel] [PATCH 0/7] monitor: Completion support for various commands.

[Luiz Capitulino]

On Sun,  9 Mar 2014 12:16:10 +0100
Hani Benhabiles <address@hidden> wrote:

> This patch series adds a new callback to mon_cmd_t which will make adding
> completion support for more commands cleaner.
> 
> It then adds full or partial arguments completion for 7 different hmp 
> commands.

The general approach seems OK to me, but I could use some help to review
the entire series.

Stefan, could you please review the set_link(), netdev_add/del() changes?

> 
> Hani Benhabiles (7):
>   monitor: Add command_completion callback to mon_cmd_t.
>   monitor: Add chardev-remove id argument completion.
>   monitor: Add chardev-add backend argument completion.
>   monitor: Add cpu index argument completion.
>   monitor: Add set_link arguments completion.
>   monitor: Add netdev_add type argument completion.
>   monitor: Add netdev_del id argument completion.
> 
>  hmp-commands.hx |  14 +++-
>  hmp.h           |  11 +++
>  monitor.c       | 213 
> +++++++++++++++++++++++++++++++++++++++++++++++++-------
>  3 files changed, 211 insertions(+), 27 deletions(-)
>