Re: [Qemu-devel] [RFC PATCH V2 3/5] qapi script: add event support by qapi-event.py

[Benoît Canet]

The Wednesday 26 Mar 2014 à 13:42:38 (+0100), Markus Armbruster wrote :
> Wenchao Xia <address@hidden> writes:
> 
> > 于 2014/3/21 6:29, Eric Blake 写道:
> >> On 03/18/2014 08:38 PM, Wenchao Xia wrote:
> >>> 于 2014/3/7 2:49, Eric Blake 写道:
> >>>> On 01/02/2014 04:10 PM, Wenchao Xia wrote:
> >>>>> qapi-event.py will parse the schema and generate qapi-event.c, then
> >>>>> the API in qapi-event.c can be used to handle event in qemu code.
> >>>>> All API have prefix "qapi_event", all types have prefix "QAPIEvent".
> >>>>> Examples can be found in following patches.
> >>>>>
> >>>>> +for o, a in opts:
> >>>>> +    if o in ("-p", "--prefix"):
> >>>>> +        prefix = a
> >>>>> +    elif o in ("-o", "--output-dir"):
> >>>>> +        output_dir = a + "/"
> >>>>> +    elif o in ("-c", "--source"):
> >>>>> +        do_c = True
> >>>>> +    elif o in ("-h", "--header"):
> >>>>> +        do_h = True
> >>>>> +    elif o in ("-b", "--builtins"):
> >>>>> +        do_builtins = True
> >>>> You may need to rebase this on top of other patches that refactor the
> >>>> qapi generators to track the input file, for improved error messages.
> >>>    It seems qapi-visit.py and qapi-types.py remains the same as above in
> >>> upstream, which kind of change are your referring to?
> >> Lluís' patch to use an explicit input file via a new -i option:
> >> https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg05220.html
> >>
> > I see, will adjust it.
> 
> Part of "[PATCH v4 0/3] qapi: Allow modularization of QAPI schema
> files".  There's also Benoît's "[PATCH 0/2] Create and include directive
> for QAPI JSON files"[*].  Benoît, care to explain how the two are
> related?

I don't see the relation excepted that my patch changes the various 
qapi-generators
to accept their input files as argv[1].

The purpose of my patch is to implement a directive to modularise the pseudo 
JSON
files we use. Lluis told me that he would not have the time to work on his 
series
until the end of the month so I picked up the ball.

Best regards

Benoît

> 
> Wenchao, please note "you *may* need to rebase".  First patch in wins :)
> 
> [*] https://lists.nongnu.org/archive/html/qemu-devel/2014-03/msg04412.html