[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v23 03/32] qapi: output def_value_str when query
From: |
Chun Yan Liu |
Subject: |
Re: [Qemu-devel] [PATCH v23 03/32] qapi: output def_value_str when query command line options |
Date: |
Sun, 23 Mar 2014 21:18:37 -0600 |
I'll update.
All patch series could also be available from:
https://github.com/chunyanliu/qemu/commits/QemuOpts
>>> On 3/22/2014 at 07:27 AM, in message <address@hidden>, Eric Blake
<address@hidden> wrote:
> On 03/21/2014 04:12 AM, Chunyan Liu wrote:
> > Change qapi interfaces to output the newly added def_value_str when
> querying
> > command line options.
> >
> > Reviewed-by: Eric Blake <address@hidden>
> > Signed-off-by: Dong Xu Wang <address@hidden>
> > Signed-off-by: Chunyan Liu <address@hidden>
> > ---
> > qapi-schema.json | 6 +++++-
> > qmp-commands.hx | 2 ++
> > util/qemu-config.c | 4 ++++
> > 3 files changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/qapi-schema.json b/qapi-schema.json
> > index b68cd44..cf9174e 100644
> > --- a/qapi-schema.json
> > +++ b/qapi-schema.json
> > @@ -4088,12 +4088,16 @@
> > #
> > # @help: #optional human readable text string, not suitable for parsing.
> > #
> > +# @default: #optional string representation of the default used
> > +# if the option is omitted. (since 2.0)
>
> We've missed 2.0; this needs to be 2.1 now.
>
> However, I'm okay if you keep my Reviewed-by with just that change.
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
>
- [Qemu-devel] [PATCH v23 00/32] replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 02/32] add def_value_str to QemuOptDesc, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 03/32] qapi: output def_value_str when query command line options, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 01/32] move find_desc_by_name ahead for later calling, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 06/32] add qemu_opt_get_*_del functions for replace work, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 05/32] move qemu_opt_del ahead for later calling, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 07/32] add qemu_opts_print_help to replace print_option_help, Chunyan Liu, 2014/03/21