Re: [Qemu-devel] [PATCH 2/3] block: Replaced old error handling with error reporting API.

[Peter Crosthwaite]

On Mon, Mar 17, 2014 at 7:10 AM, Maria Kustova <address@hidden> wrote:
> Signed-off-by: Maria Kustova <address@hidden>
> ---
>  block/curl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/curl.c b/block/curl.c
> index 3494c6d..359637e 100644
> --- a/block/curl.c
> +++ b/block/curl.c
> @@ -538,7 +538,7 @@ static int curl_open(BlockDriverState *bs, QDict 
> *options, int flags,
>      return 0;
>
>  out:
> -    fprintf(stderr, "CURL: Error opening file: %s\n", state->errmsg);
> +    error_setg(errp, "CURL: Error opening file: %s\n", state->errmsg);

You should drop \n from error_setg calls.

Regards,
Peter

>      curl_easy_cleanup(state->curl);
>      state->curl = NULL;
>  out_noclean:
> --
> 1.8.2.1
>
>