qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/6] Refactor AES Instructions


From: Tom Musta
Subject: Re: [Qemu-devel] [PATCH 0/6] Refactor AES Instructions
Date: Thu, 13 Mar 2014 08:14:54 -0500
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

On 3/12/2014 5:40 PM, Richard Henderson wrote:
> On 03/10/2014 12:04 PM, Tom Musta wrote:
>> This patch series addresses concerns raised by Richard Henderson regarding 
>> redundant
>> copies of Advanced Encryption Standard (AES) data and code (see
>> http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg04391.html).
>>
>> The patches declare commonly used AES tables in the include/qemu/aes.h 
>> header file
>> and define the tables in util/aes.c, thus eliminating redundant copies.
>>
>> Minor refactorization of the i386 and ARM instruction models are made to 
>> utilize
>> this common support.  The newly added PowerPC instructions are completely 
>> rewritten and look much more like the i386 equivalents; a substantial amount 
>> of
>> code is eliminated.
>>
>> Tom Musta (6):
>>   util: Add S-Box and InvS-Box Arrays to Common AES Utils
>>   util: Add AES ShiftRows and InvShiftRows Tables
>>   util: Add InvMixColumns
>>   target-i386: Use Common ShiftRows and InvShiftRows Tables
>>   target-arm: Use Common Tables in AES Instructions
>>   target-ppc: Refactor AES Instructions
> 
> Other than the one nit,
> 
> Reviewed-by: Richard Henderson <address@hidden>
> 
> 
> r~
> 
Thanks.  I will rework the nit and republish a V2.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]