[Qemu-devel] [v3 PATCH 00/13] SMBIOS: build full tables in QEMU

[Gabriel L. Somlo]

From: "Gabriel L. Somlo" <address@hidden>

On Wed, Mar 12, 2014 at 09:20:54AM +0100, Gerd Hoffmann wrote:
> On Tue, Mar 11, 2014 at 11:46:17AM -0400, Kevin O'Connor wrote:
> > I would suggest being "bug for bug" compatible in the first set of
> > patches, and then add patches on top to add the additional
> > functionality.  Just my 2 cents.
> 
> Makes sense indeed.
> ...
> Just move patch #1 to the end of the series.  So we first switch over
> table by table, generating output identical to current seabios, then go
> fix/improve things on top of that.  That way it'll be easier to bisect
> problems in case any show up.

OK, after patch 12/13 we're fully 100% still compatible with SeaBIOS.
Then, patch 13/13 adds v2.3 compliance for types 4 and 17.

Should we add another patch (14) to remove the manufacturer string
compatibility hack ?

I'm replying separately to the e820 suggestion, as maintaining SeaBIOS
compatibility there is slightly trickier, and maybe we can decouple that
from this set of patches ?

Thanks,
--Gabriel

Gabriel L. Somlo (13):
  SMBIOS: Rename smbios_set_type1_defaults() for more general use
  SMBIOS: Use macro to set smbios defaults
  SMBIOS: Use bitmaps to check for smbios table collisions
  SMBIOS: Add code to build full smbios tables; build type 2 table
  SMBIOS: Build full tables for types 0 and 1
  SMBIOS: Remove unused code for passing individual fields to bios
  SMBIOS: Build full type 3 table
  SMBIOS: Build full type 4 tables
  SMBIOS: Build full smbios type 16 and 17 tables
  SMBIOS: Build full type 19 tables
  SMBIOS: Build full type 20 tables
  SMBIOS: Build full tables for type 32 and 127
  SMBIOS: Update all table definitions to smbios spec v2.3

 hw/i386/pc.c             |   3 +
 hw/i386/pc_piix.c        |  15 +-
 hw/i386/pc_q35.c         |  11 +-
 hw/i386/smbios.c         | 674 ++++++++++++++++++++++++++++++++++++++++-------
 include/hw/i386/smbios.h |  40 ++-
 5 files changed, 627 insertions(+), 116 deletions(-)

-- 
1.8.1.4