[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qcow2: Don't write with BDRV_O_INCOMING
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] qcow2: Don't write with BDRV_O_INCOMING |
|
Date: |
Tue, 11 Mar 2014 19:45:55 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Mar 11, 2014 at 03:15:03PM +0100, Kevin Wolf wrote:
> qcow2_open() causes writes when repairing an image with the dirty flag
> set and when clearing autoclear flags. It shouldn't do this when another
> qemu instance is still actively working on this image file.
>
> One effect of the bug is that images may have a cleared dirty flag while
> the migration source host still has it in use with lazy refcounts
> enabled, so refcounts are not accurate and the dirty flag must remain
> set.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/qcow2.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan