Re: [Qemu-devel] [PATCH v2 0/5] w32: Reduce dependency on Windows API

[Stefan Hajnoczi]

On Fri, Mar 07, 2014 at 11:17:42PM +0100, Stefan Weil wrote:
> The first 4 patches reduce the number of files which depend on
> windows.h by about 90 percent.
> 
> This reduces the compilation time, allows
> removing some hacks and avoids name space pollution.
> 
> Patch 5 is optional and new here.
> 
> Changes in v2:
> 
> * Change name of new include file include/qemu/winapi.h
>   (suggested by Paolo Bonzini)
> 
> * Don't replace Win32 data types in block/raw-aio.h
>   (suggested by Kevin Wolf)
> 
> * Replace Win32 data types in central header files by
>   new QEMU data types instead of basic C data types
>   (suggested by Peter Maydell and Stefan Hajnoczi)
> 
> [PATCH v2 1/5] w32: Add and use intermediate include file for windows.h
> [PATCH v2 2/5] w32: Move inline function from header file to C source
> [PATCH v2 3/5] w32: Reduce dependencies in sysemu/os-win32.h
> [PATCH v2 4/5] w32: Replace Windows specific data types in common
> [PATCH v2 5/5] block: Review include statements for winioctl.h

Personally, I think the code was nicer without adding this indirection
to avoid longer compile times.  But then you're one of the few people
who cares about Windows, so if it makes your life easier that's a good
thing.

Stefan