[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 8/9] ui/vnc: optimize setting in vnc_dpy_update()
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 8/9] ui/vnc: optimize setting in vnc_dpy_update() |
Date: |
Mon, 10 Mar 2014 13:49:12 +0100 |
From: Peter Lieven <address@hidden>
Signed-off-by: Peter Lieven <address@hidden>
Reviewed-by: Wenchao Xia <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/vnc.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index e1d6ca3..25e4380 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -430,30 +430,24 @@ static int vnc_refresh_server_surface(VncDisplay *vd);
static void vnc_dpy_update(DisplayChangeListener *dcl,
int x, int y, int w, int h)
{
- int i;
VncDisplay *vd = container_of(dcl, VncDisplay, dcl);
struct VncSurface *s = &vd->guest;
int width = surface_width(vd->ds);
int height = surface_height(vd->ds);
- h += y;
-
- /* round x down to ensure the loop only spans one 16-pixel block per,
- iteration. otherwise, if (x % 16) != 0, the last iteration may span
- two 16-pixel blocks but we only mark the first as dirty
- */
+ /* this is needed this to ensure we updated all affected
+ * blocks if x % VNC_DIRTY_PIXELS_PER_BIT != 0 */
w += (x % VNC_DIRTY_PIXELS_PER_BIT);
x -= (x % VNC_DIRTY_PIXELS_PER_BIT);
x = MIN(x, width);
y = MIN(y, height);
w = MIN(x + w, width) - x;
- h = MIN(h, height);
+ h = MIN(y + h, height);
for (; y < h; y++) {
- for (i = 0; i < w; i += VNC_DIRTY_PIXELS_PER_BIT) {
- set_bit((x + i) / VNC_DIRTY_PIXELS_PER_BIT, s->dirty[y]);
- }
+ bitmap_set(s->dirty[y], x / VNC_DIRTY_PIXELS_PER_BIT,
+ DIV_ROUND_UP(w, VNC_DIRTY_PIXELS_PER_BIT));
}
}
--
1.8.3.1
- [Qemu-devel] [PULL 0/9] vnc patches, Gerd Hoffmann, 2014/03/10
- [Qemu-devel] [PULL 3/9] vnc: fix use-after-free in vnc_update_client_sync, Gerd Hoffmann, 2014/03/10
- [Qemu-devel] [PULL 2/9] vnc: Fix qemu crashed when vnc client disconnect suddenly, Gerd Hoffmann, 2014/03/10
- [Qemu-devel] [PULL 1/9] vnc: Fix tight_detect_smooth_image() for lossless case, Gerd Hoffmann, 2014/03/10
- [Qemu-devel] [PULL 4/9] ui/vnc: introduce VNC_DIRTY_PIXELS_PER_BIT macro, Gerd Hoffmann, 2014/03/10
- [Qemu-devel] [PULL 6/9] ui/vnc: optimize dirty bitmap tracking, Gerd Hoffmann, 2014/03/10
- [Qemu-devel] [PULL 9/9] ui/vnc: disable adaptive update calculations if not needed, Gerd Hoffmann, 2014/03/10
- [Qemu-devel] [PULL 7/9] ui/vnc: optimize clearing in find_and_clear_dirty_height(), Gerd Hoffmann, 2014/03/10
- [Qemu-devel] [PULL 8/9] ui/vnc: optimize setting in vnc_dpy_update(),
Gerd Hoffmann <=
- [Qemu-devel] [PULL 5/9] ui/vnc: derive cmp_bytes from VNC_DIRTY_PIXELS_PER_BIT, Gerd Hoffmann, 2014/03/10
- Re: [Qemu-devel] [PULL 0/9] vnc patches, Peter Maydell, 2014/03/11