Re: [Qemu-devel] [PATCH qom-cpu 0/6] cpu: Unifying features parsing

[Andreas Färber]

Am 08.03.2014 21:50, schrieb Mark Cave-Ayland:
> On 04/03/14 20:32, Andreas Färber wrote:
> 
>> Am 04.03.2014 03:55, schrieb Andreas Färber:
>>> Hello,
>>>
>>> Prompted by Alexey's desire for tweakable PowerPCCPU properties but
>>> also by
>>> Peter's wish for ARMCPU properties, this series sets out to align
>>> cpu_model
>>> parsing across targets.
>>>
>>> QemuOpts would've been nice to use, but on the one hand x86 and sparc
>>> use
>>> QemuOpts-incompatible +foo and -foo syntax (which accumulate rather
>>> than apply
>>> immediately) and on the other linux-user and bsd-user don't use
>>> QemuOpts at all.
>>>
>>> The x86 implementation is closest to the proposed API, save for some
>>> laziness.
>>> SPARC is brought in line. And as fallback for the remaining targets a
>>> new
>>> implementation, derived from x86 but supporting only key=value
>>> format, is added.
>>>
>>> To facilitate using this infrastructure, a generic CPU init function
>>> is created.
>>>
>>> Only lightly tested. Available at:
>>> git://github.com/afaerber/qemu-cpu.git qom-cpu-features.v1
>>> https://github.com/afaerber/qemu-cpu/commits/qom-cpu-features.v1
>>>
>>> Regards,
>>> Andreas
>>>
>>> Cc: Alexey Kardashevskiy<address@hidden>
>>> Cc: Peter Maydell<address@hidden>
>>> Cc: Anthony Liguori<address@hidden>
>>>
>>> Andreas Färber (6):
>>>    cpu: Introduce CPUClass::parse_features() hook
>>>    target-sparc: Use error_report() for CPU error reporting
>>>    target-sparc: Implement CPUClass::parse_features() for SPARCCPU
>>>    target-sparc: Defer SPARCCPU feature inference to QOM realize
>>
>> Mark and Fabien, forgot to CC you: Could you take a look at the sparc
>> parts and give them some testing please?
>>
>> The very latest version can be found on qom-cpu-ppc branch if necessary.
>>
>> Thanks,
>> Andreas
> 
> Hi Andreas,
> 
> I've had a quick test of this branch, and while I don't tend to use CPU
> options that much, the parsing seems to work as I might expect from
> looking at the changes. I think any other snags if they exist can be
> picked up during pre-release testing so:
> 
> Tested-by: Mark Cave-Ayland <address@hidden>

Thanks a lot, proceeding to staging it on qom-cpu-next:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu-next

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg