[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] misc: Fix typos in comments
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH] misc: Fix typos in comments |
Date: |
Fri, 07 Mar 2014 20:06:20 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 07.03.2014 19:48, schrieb Stefan Weil:
> Codespell found and fixed these new typos:
>
> * doesnt -> doesn't
> * funtion -> function
> * perfomance -> performance
> * remaing -> remaining
>
> A code style issue (line too long) was fixed manually.
"coding style"?
>
> Signed-off-by: Stefan Weil <address@hidden>
[...]
> diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c
> index 7760272..d7c38fa 100644
> --- a/hw/net/fsl_etsec/rings.c
> +++ b/hw/net/fsl_etsec/rings.c
> @@ -195,8 +195,8 @@ static void process_tx_fcb(eTSEC *etsec)
>
> /* if packet is IP4 and IP checksum is requested */
> if (flags & FCB_TX_IP && flags & FCB_TX_CIP) {
> - /* do IP4 checksum (TODO This funtion does TCP/UDP checksum but not
> sure
> - * if it also does IP4 checksum. */
> + /* do IP4 checksum (TODO This function does TCP/UDP checksum
> + * but not sure if it also does IP4 checksum. */
While rebreaking it, you could've also added the missing parenthesis,
after the dot I guess. Apart from that,
Reviewed-by: Andreas Färber <address@hidden>
Thanks,
Andreas
> net_checksum_calculate(etsec->tx_buffer + 8,
> etsec->tx_buffer_len - 8);
> }
[snip]
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg