[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] block/raw-posix: bdrv_parse_filename() for
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] block/raw-posix: bdrv_parse_filename() for hdev |
Date: |
Thu, 6 Mar 2014 23:38:25 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
The Thursday 06 Mar 2014 à 23:25:35 (+0100), Max Reitz wrote :
> The "host_device" protocol driver should strip the "host_device:" prefix
> from filenames if present.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/raw-posix.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index e6b4c1f..ab32ff9 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -1561,6 +1561,15 @@ static int check_hdev_writable(BDRVRawState *s)
> return 0;
> }
>
> +static void hdev_parse_filename(const char *filename, QDict *options,
> + Error **errp)
> +{
> + /* The prefix is optional, just as for "file". */
> + strstart(filename, "host_device:", &filename);
> +
> + qdict_put_obj(options, "filename", QOBJECT(qstring_from_str(filename)));
> +}
> +
> static int hdev_open(BlockDriverState *bs, QDict *options, int flags,
> Error **errp)
> {
> @@ -1805,6 +1814,7 @@ static BlockDriver bdrv_host_device = {
> .instance_size = sizeof(BDRVRawState),
> .bdrv_needs_filename = true,
> .bdrv_probe_device = hdev_probe_device,
> + .bdrv_parse_filename = hdev_parse_filename,
> .bdrv_file_open = hdev_open,
> .bdrv_close = raw_close,
> .bdrv_reopen_prepare = raw_reopen_prepare,
> --
> 1.9.0
>
Reviewed-by: Benoit Canet <address@hidden>
- [Qemu-devel] [PATCH 0/5] block: Strip protocol prefixes from filenames, Max Reitz, 2014/03/06
- [Qemu-devel] [PATCH 1/5] block/raw-posix: bdrv_parse_filename() for hdev, Max Reitz, 2014/03/06
- Re: [Qemu-devel] [PATCH 1/5] block/raw-posix: bdrv_parse_filename() for hdev,
Benoît Canet <=
- [Qemu-devel] [PATCH 2/5] block/raw-posix: bdrv_parse_filename() for floppy, Max Reitz, 2014/03/06
- [Qemu-devel] [PATCH 3/5] block/raw-posix: bdrv_parse_filename() for cdrom, Max Reitz, 2014/03/06
- [Qemu-devel] [PATCH 4/5] block/raw-posix: Strip protocol prefix on creation, Max Reitz, 2014/03/06
- [Qemu-devel] [PATCH 4/5] block/raw-posix: Strip protocol prefix on creation, Max Reitz, 2014/03/06