[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] qdev-monitor-test: Simplify & make more
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] qdev-monitor-test: Simplify & make more robust |
Date: |
Thu, 06 Mar 2014 20:16:47 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 06.03.2014 10:12, schrieb Markus Armbruster:
> Stefan's patch has been rotting on the list since December. Reposting
> it together with a patch for a robustness issue I spotted when
> reviewing it.
Stefan had applied qdev-monitor-test through his block tree, and I was
on vacation for most of December and would've needed a ping or two in
the new year. qdev-monitor itself seems to be gray territory - I've been
taking care of QOM conversion issues but otherwise don't feel
responsible for the HMP/QMP interface and would expect the maintainer
that does feel responsible to handle the matching test cases.
> Markus Armbruster (1):
> qdev-monitor-test: Don't test human-readable error message
>
> Stefan Hajnoczi (1):
> qdev-monitor-test: simplify using g_assert_cmpstr()
>
> tests/qdev-monitor-test.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
Thanks, applied to qom-next:
https://github.com/afaerber/qemu-cpu/commits/qom-next
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg