[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [QEMU 2.0 FIX V2] block: make bdrv_swap rebuild the bs
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [QEMU 2.0 FIX V2] block: make bdrv_swap rebuild the bs graph node list field. |
Date: |
Thu, 6 Mar 2014 11:33:29 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 05.03.2014 um 23:48 hat Benoît Canet geschrieben:
> Moving only the node_name one field could lead to some inconsitencies where a
> node_name was defined on a bs which was not registered in the graph node list.
>
> bdrv_swap between a named node bs and a non named node bs would lead to this.
>
> bdrv_make_anon would then crash because it would try to remove the bs from the
> graph node list while it is not in it.
>
> This patch remove named node bses from the graph node list before doing the
> swap
> then insert them back.
>
> Signed-off-by: Benoit Canet <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
Thanks, applied to the block branch.
Kevin