qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2.1 28/28] qmp: add query-memdev


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 2.1 28/28] qmp: add query-memdev
Date: Tue, 04 Mar 2014 19:11:53 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

Il 04/03/2014 18:37, Eric Blake ha scritto:
On 03/04/2014 07:00 AM, Paolo Bonzini wrote:
From: Hu Tao <address@hidden>

Add qmp command query-memdev to query for information
of memory devices

Signed-off-by: Hu Tao <address@hidden>
[Use QMP visitors instead of String visitors. - Paolo]
Signed-off-by: Paolo Bonzini <address@hidden>
---
 numa.c           | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 qapi-schema.json | 31 +++++++++++++++++++++++++++
 qmp-commands.hx  | 32 ++++++++++++++++++++++++++++
 3 files changed, 127 insertions(+)


+++ b/qapi-schema.json
@@ -4576,3 +4576,34 @@
 ##
 { 'enum': 'HostMemPolicy',
   'data': [ 'default', 'preferred', 'membind', 'interleave' ] }
+
+##
+# @Memdev:
+#
+# Information of memory device
+#
+# @size: memory device size
+#
+# @host-nodes: host nodes for its memory policy
+#
+# @policy: memory policy of memory device
+#
+# Since: 2.1
+##
+
+{ 'type': 'Memdev',
+  'data': {
+    'size':       'size',
+    'host-nodes': ['uint16'],
+    'policy':     'str' }}

Why is policy 'str', when you just defined 'HostMemPolicy' as an enum in
the previous patch?  Should this be using the enum?

Good catch.


+<- { "return": [
+       {
+         "size": 536870912,
+         "host-nodes": [0, 1],
+         "policy": "bind"

"bind" is not one of the values of HostMemPolicy - is that missing from
patch 27/28?

Should be membind.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]