[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2.1 02/28] NUMA: check if the total numa memory size
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 2.1 02/28] NUMA: check if the total numa memory size is equal to ram_size |
Date: |
Tue, 4 Mar 2014 15:00:30 +0100 |
From: Wanlong Gao <address@hidden>
If the total number of the assigned numa nodes memory is not
equal to the assigned ram size, it will write the wrong data
to ACPI talb, then the guest will ignore the wrong ACPI table
and recognize all memory to one node. It's buggy, we should
check it to ensure that we write the right data to ACPI table.
Signed-off-by: Wanlong Gao <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
numa.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/numa.c b/numa.c
index 395c14f..8ba66f1 100644
--- a/numa.c
+++ b/numa.c
@@ -127,6 +127,7 @@ void numa_add(const char *optarg)
void set_numa_nodes(void)
{
if (nb_numa_nodes > 0) {
+ uint64_t numa_total;
int i;
if (nb_numa_nodes > MAX_NODES) {
@@ -154,6 +155,16 @@ void set_numa_nodes(void)
node_mem[i] = ram_size - usedmem;
}
+ numa_total = 0;
+ for (i = 0; i < nb_numa_nodes; i++) {
+ numa_total += node_mem[i];
+ }
+ if (numa_total != ram_size) {
+ fprintf(stderr, "qemu: numa nodes total memory size "
+ "should equal to ram_size\n");
+ exit(1);
+ }
+
for (i = 0; i < nb_numa_nodes; i++) {
if (!bitmap_empty(node_cpumask[i], MAX_CPUMASK_BITS)) {
break;
--
1.8.5.3
- [Qemu-devel] [PATCH 2.1 00/28] Current state of NUMA series, and hostmem improvements, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 01/28] NUMA: move numa related code to new file numa.c, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 02/28] NUMA: check if the total numa memory size is equal to ram_size,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 2.1 03/28] NUMA: Add numa_info structure to contain numa nodes info, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 04/28] NUMA: convert -numa option to use OptsVisitor, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 05/28] NUMA: expand MAX_NODES from 64 to 128, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 06/28] man: improve -numa doc, Paolo Bonzini, 2014/03/04
- [Qemu-devel] [PATCH 2.1 07/28] qemu-option: introduce qemu_find_opts_singleton, Paolo Bonzini, 2014/03/04