Re: [Qemu-devel] [PATCH v5 5/7] qdev: make get_pointer() handle temporary strings

[Stefan Hajnoczi]

On Fri, Feb 28, 2014 at 05:49:09PM +0100, Andreas Färber wrote:
> Am 28.02.2014 16:18, schrieb Stefan Hajnoczi:
> > From: Igor Mammedov <address@hidden>
> > 
> > get_pointer()'s print() callback might return a heap allocated
> > string, to avoid adding dedicated get_pointer_foo for this case
> > convert current print() callbacks to return temporary heap
> > allocated string and make get_pointer() free it.
> > 
> > Signed-off-by: Igor Mammedov <address@hidden>
> > Signed-off-by: Stefan Hajnoczi <address@hidden>
> > ---
> >  hw/core/qdev-properties-system.c | 19 +++++++++++--------
> >  1 file changed, 11 insertions(+), 8 deletions(-)
> 
> Not aware of the history of this patch (not CC'ed?) but looks okay,
> 
> Reviewed-by: Andreas Färber <address@hidden>
> 
> Do we have any users outside of this series?

The patch comes from Igor originally so maybe he has future patches that
will use it.

Stefan