qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 5/7] qdev: make get_pointer() handle temporar


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH v5 5/7] qdev: make get_pointer() handle temporary strings
Date: Fri, 28 Feb 2014 17:49:09 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

Am 28.02.2014 16:18, schrieb Stefan Hajnoczi:
> From: Igor Mammedov <address@hidden>
> 
> get_pointer()'s print() callback might return a heap allocated
> string, to avoid adding dedicated get_pointer_foo for this case
> convert current print() callbacks to return temporary heap
> allocated string and make get_pointer() free it.
> 
> Signed-off-by: Igor Mammedov <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  hw/core/qdev-properties-system.c | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)

Not aware of the history of this patch (not CC'ed?) but looks okay,

Reviewed-by: Andreas Färber <address@hidden>

Do we have any users outside of this series?

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]