[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V8 08/10] qapi: convert BlockdevOptions to use e
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V8 08/10] qapi: convert BlockdevOptions to use enum discriminator |
Date: |
Thu, 27 Feb 2014 14:54:12 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/27/2014 04:09 AM, Wenchao Xia wrote:
> From: Wenchao Xia <address@hidden>
>
> After this patch, hidden enum type BlockdevOptionsKind will not
> be generated, and other API can use enum BlockdevDriver.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> Signed-off-by: Wenchao Xia <address@hidden>
Double S-o-B.
> ---
> qapi-schema.json | 14 +++++++++++++-
> 1 files changed, 13 insertions(+), 1 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index fcb2280..7f587b4 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -4200,6 +4200,18 @@
> '*no-flush': 'bool' } }
>
> ##
> +# @BlockdevDriver
> +#
> +# Drivers that are supported in block device operations.
> +#
> +# Since: 2.0
> +##
> +{ 'enum': 'BlockdevDriver',
> + 'data': [ 'file', 'http', 'https', 'ftp', 'ftps', 'tftp', 'vvfat',
> 'blkdebug',
> + 'blkverify', 'bochs', 'cloop', 'cow', 'dmg', 'parallels', 'qcow',
> + 'qcow2', 'qed', 'raw', 'vdi', 'vhdx', 'vmdk', 'vpc', 'quorum' ] }
I see you've picked up 'quorum' since last time :)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH V8 03/10] qapi script: remember line number in schema parsing, (continued)
- [Qemu-devel] [PATCH V8 04/10] qapi script: check correctness of union, Wenchao Xia, 2014/02/27
- [Qemu-devel] [PATCH V8 05/10] qapi script: code move for generate_enum_name(), Wenchao Xia, 2014/02/27
- [Qemu-devel] [PATCH V8 06/10] qapi script: use same function to generate enum string, Wenchao Xia, 2014/02/27
- [Qemu-devel] [PATCH V8 07/10] qapi script: support enum type as discriminator in union, Wenchao Xia, 2014/02/27
- [Qemu-devel] [PATCH V8 08/10] qapi: convert BlockdevOptions to use enum discriminator, Wenchao Xia, 2014/02/27
- Re: [Qemu-devel] [PATCH V8 08/10] qapi: convert BlockdevOptions to use enum discriminator,
Eric Blake <=
- [Qemu-devel] [PATCH V8 09/10] qapi script: do not allow string discriminator, Wenchao Xia, 2014/02/27
- [Qemu-devel] [PATCH V8 10/10] qapi script: do not add "_" for every capitalized char in enum, Wenchao Xia, 2014/02/27
- Re: [Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name, Wenchao Xia, 2014/02/28