Re: [Qemu-devel] git build from clean broken?

[Paolo Bonzini]

Il 27/02/2014 20:57, Stefan Weil ha scritto:
> Yes. I saw that problem, too. This patch for Makefile fixed it for me:
> 
> index ccab967,a28a3c8..8ec3a99
> @@@ -170,6 -159,6 +170,7 @@@ qemu-options.def: $(SRC_PATH)/qemu-opti
>   SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))
>   SOFTMMU_SUBDIR_RULES=$(filter %-softmmu,$(SUBDIR_RULES))
> 
> ++$(SOFTMMU_SUBDIR_RULES): $(block-obj-y)
>   $(SOFTMMU_SUBDIR_RULES): config-all-devices.mak

This is correct.  Alternatively:

------------------ 8< --------------------
From: Paolo Bonzini <address@hidden>
Subject: [PATCH] build: build block-obj-y explicitly before recursing

block-obj-y is not anymore part of common-obj-y, because "nesting"
variables is complicated and requires specifying the correct
ordering in the calls to unnest-vars.  However, because of this
we need to specify block-obj-y in the dependencies of the
target subdirectories.

Signed-off-by: Paolo Bonzini <address@hidden>

diff --git a/Makefile b/Makefile
index a443cd4..3938b6c 100644
--- a/Makefile
+++ b/Makefile
@@ -167,7 +167,7 @@ subdir-dtc:dtc/libfdt dtc/tests
 dtc/%:
        mkdir -p $@
 
-$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y)
+$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) $(block-obj-y)
 
 ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS))
 romsubdir-%:
-- 
1.8.5.3

Paolo