[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH target-arm v2 2/7] dma/pl330: Fix misleading type
From: |
Peter Crosthwaite |
Subject: |
[Qemu-devel] [PATCH target-arm v2 2/7] dma/pl330: Fix misleading type |
Date: |
Tue, 25 Feb 2014 15:57:50 -0800 |
This type really should just be a regular int as no usages rely on it's
32 bitness (it's only meaningful as a bit position and not a bit mask).
This also fixes a printf which uses the variable with a regular %d.
Signed-off-by: Peter Crosthwaite <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
---
hw/dma/pl330.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/dma/pl330.c b/hw/dma/pl330.c
index 68adf39..d36f0bc 100644
--- a/hw/dma/pl330.c
+++ b/hw/dma/pl330.c
@@ -1310,7 +1310,7 @@ static void pl330_iomem_write(void *opaque, hwaddr offset,
uint64_t value, unsigned size)
{
PL330State *s = (PL330State *) opaque;
- uint32_t i;
+ int i;
DB_PRINT("addr: %08x data: %08x\n", (unsigned)offset, (unsigned)value);
--
1.9.0.1.g4196000
- [Qemu-devel] [PATCH target-arm v2 0/7] PL330 Changes, Peter Crosthwaite, 2014/02/25
- [Qemu-devel] [PATCH target-arm v2 1/7] dma/pl330: Delete overly verbose debug printf, Peter Crosthwaite, 2014/02/25
- [Qemu-devel] [PATCH target-arm v2 2/7] dma/pl330: Fix misleading type,
Peter Crosthwaite <=
- [Qemu-devel] [PATCH target-arm v2 3/7] dma/pl330: printf format type sweep., Peter Crosthwaite, 2014/02/25
- [Qemu-devel] [PATCH target-arm v2 4/7] dma/pl330: Rename parent_obj, Peter Crosthwaite, 2014/02/25
- [Qemu-devel] [PATCH target-arm v2 5/7] dma/pl330: Add event debugging printfs, Peter Crosthwaite, 2014/02/25
- [Qemu-devel] [PATCH target-arm v2 6/7] dma/pl330: Fix buffer depth, Peter Crosthwaite, 2014/02/25
- [Qemu-devel] [PATCH target-arm v2 7/7] dma/pl330: implement dmaadnh instruction, Peter Crosthwaite, 2014/02/25
- Re: [Qemu-devel] [PATCH target-arm v2 0/7] PL330 Changes, Peter Maydell, 2014/02/26